Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

current-exe-mismatch.rs test may be too eager to ignore its failings #489

Open
pnkfelix opened this issue Oct 25, 2022 · 0 comments
Open
Labels

Comments

@pnkfelix
Copy link
Member

Spawned off of #488 (comment)

The newly added current-exe-mismatch.rs is a bit over-eager to categorize problems as "ignorable" rather than providing some way to flag them as a hard-error in certain contexts.

The main example: while it is not reasonable to expect readelf to exist on every target, it may be reasonable to assume its available on Linux (yes?), and thus maybe a readelf invocation failure should be ignored on non-Linux systems, but a test failure on Linux systems. (Or maybe just treat it as a test failure on Linux Continuous Integration hosts, which is what we really care about here...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants