Make AsyncRead::initializer unstable API #1845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
commented
Aug 30, 2019
futures-io/src/lib.rs
Outdated
| @@ -42,9 +45,11 @@ mod if_std { | |||
|
|
|||
| /// A type used to conditionally initialize buffers passed to `AsyncRead` | |||
| /// methods, modeled after `std`. | |||
| #[cfg(feature = "read_initializer")] | |||
| #[derive(Debug)] | |||
| pub struct Initializer(bool); | |||
There was a problem hiding this comment.
Is it better to re-export the std ones instead of our own ones? (The stability of this feature depends on it.)
taiki-e
force-pushed
the
io-read_initializer
branch
8 times, most recently
from
cff39cb
to
43c5f14
Compare
taiki-e
commented
Aug 30, 2019
| /// `unsafe` because the `io::Read` type must not access the buffer | ||
| /// before reading data into it. | ||
| macro_rules! unsafe_delegate_async_read_to_stdio { | ||
| macro_rules! delegate_async_read_to_stdio { |
taiki-e
force-pushed
the
io-read_initializer
branch
from
43c5f14
to
c42c7ab
Compare
bors bot
added a commit
to async-rs/async-std
that referenced
this pull request
Oct 1, 2019
255: Update futures-preview to 0.3.0-alpha.19 r=skade a=taiki-e Depends on http-rs/surf#74 Refs: * rust-lang/futures-rs#1761 * rust-lang/futures-rs#1845 cc @skade @stjepang @yoshuawuyts Co-authored-by: Taiki Endo <te316e89@gmail.com>
bors bot
added a commit
to async-rs/async-std
that referenced
this pull request
Oct 1, 2019
255: Update futures-preview to 0.3.0-alpha.19 r=skade a=taiki-e Depends on http-rs/surf#74 Refs: * rust-lang/futures-rs#1761 * rust-lang/futures-rs#1845 cc @skade @stjepang @yoshuawuyts Co-authored-by: Taiki Endo <te316e89@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1761
r? @cramertj