Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use our own io::{Empy, Repeat, Sink} #1829

Merged
merged 2 commits into from Aug 27, 2019
Merged

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Aug 27, 2019

If both futures::io ext traits and std::io traits are imported, method names may conflict, so use our own.

Copy link
Member

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've had this problem in async-std as well, and having these be their own impls makes a lot of sense!

@taiki-e
Copy link
Member Author

taiki-e commented Aug 27, 2019

(btw, I'm considering adding our own Cursor in another PR. (It was a little big so I separated it from this PR))

@cramertj
Copy link
Member

I have no particularly strong feels about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants