Rewrite join! and try_join! as procedural macros #1783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
force-pushed
the
join-proc-macro
branch
from
9fe1edd
to
d6be294
Compare
taiki-e
commented
Aug 6, 2019
| @@ -27,13 +27,15 @@ cfg-target-has-atomic = ["futures-core-preview/cfg-target-has-atomic"] | |||
| sink = ["futures-sink-preview"] | |||
| io = ["std", "futures-io-preview", "memchr"] | |||
| channel = ["std", "futures-channel-preview"] | |||
| join-macro = ["async-await", "futures-join-macro-preview", "proc-macro-hack", "proc-macro-nested"] | |||
There was a problem hiding this comment.
For almost the same reason as select!, this is optional in futures_util (see #1701).
taiki-e
force-pushed
the
join-proc-macro
branch
from
d6be294
to
78665e8
Compare
|
Wow, this is awesome! I have so much appreciation for your eagerness and quick work on all of this. Thanks, @taiki-e! |
taiki-e
force-pushed
the
join-proc-macro
branch
from
78665e8
to
e5245e6
Compare
Nemo157
reviewed
Aug 7, 2019
| /// `join!` polls both futures concurrently and therefore is more efficent. | ||
| /// | ||
| /// This macro is only usable inside of async functions, closures, and blocks. | ||
| /// It is also gated behind the `async-await` feature of this library, which is |
There was a problem hiding this comment.
Suggested change
| /// It is also gated behind the `async-await` feature of this library, which is | |
| /// It is also gated behind the `join-macro` feature of this library, which is |
There was a problem hiding this comment.
Oh, it depends on what "this library" is referring to...
There was a problem hiding this comment.
Yeah. So, I would like to remove these descriptions and change them to use doc(cfg(feature = "..")) instead in the near future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1782
r? @cramertj