Skip to content
This repository has been archived by the owner on Aug 16, 2021. It is now read-only.

Should backtrace dependency be optional? #313

Open
vi opened this issue May 14, 2019 · 1 comment · May be fixed by #314
Open

Should backtrace dependency be optional? #313

vi opened this issue May 14, 2019 · 1 comment · May be fixed by #314

Comments

@vi
Copy link

vi commented May 14, 2019

Although nominally optional, backtrace is effectively required if you want to use Error or bail!.

This hinders portability, as backtrace depends on C code:

cargo:warning=src/libbacktrace/macho.c:50:2: error: #error Attempting to build Mach-O support on incorrect platform

Shall failure have some feature combination to build projects depending on failure without backtrace support, yet with typical failure's convenience features?
vi added a commit to vi/failure that referenced this issue May 15, 2019
@vi
Make backtrace-sys optional
04e8ba5 
Resolves rust-lang-deprecated#313.
@vi vi linked a pull request May 15, 2019 that will close this issue
Open
vi added a commit to vi/netmeasure2 that referenced this issue May 15, 2019
@vi
Workaround for building issue
d05f9ab 
rust-lang-deprecated/failure#313
@daboross
Copy link

See also #127

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make backtrace-sys optional vi/failure
2 participants
@vi @daboross