Skip to content
This repository has been archived by the owner on Aug 16, 2021. It is now read-only.

Book Links Fail #272

Open
pducks32 opened this issue Nov 1, 2018 · 1 comment
Open

Book Links Fail #272

pducks32 opened this issue Nov 1, 2018 · 1 comment

Comments

@pducks32
Copy link

pducks32 commented Nov 1, 2018

Hi,

All links within the book on Github fail. This is because their definitions are set to .html files and not .md files.

I was going to make a Pull Request but I am new to rust and failure and thought that maybe they are intentionally wrong to support some other use case for them (like a website version). If that is the case then maybe there is another approach that could allow both Github and this other client to both work side by side?

Steps to Reproduce

Steps to Investigate

  • Click edit on Github
  • Scroll to the link definitions at the end
  • Note the .html extension for a .md page.
@mendelt
Copy link

mendelt commented Feb 18, 2019

This works as intended.
Those md files are source code that is compiled into html for the failure book that can be found here;
https://rust-lang-nursery.github.io/failure/intro.html
The confusion arises because Github understands markdown so you can read the book here but of course without working links.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants