This repository has been archived by the owner on Aug 16, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 111
impl From<std::convert::Infallible> for Error #229
Comments
I'm not sure I understand why this impl is needed? |
I'm not really sure either, but it was triggered from the following:
where I was converting from a |
Here is the error if I comment out the impl.
|
Oh, I see. Then yes, it would be good to add it to error-chain, maybe behind a feature until TryFrom comes to stable. impl From<Infallible> for Error {
fn from(_: Infallible) -> Self {
unreachable!()
}
} |
Ah I see what this was all about now. Looks like right now we'd still need to convert from the infallible error type even if it was |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
rust-lang/rust#44174 landed in rust nightly and now I have to add
to my error chain
Error
. Can/Should this impl be included in the library?The text was updated successfully, but these errors were encountered: