Skip to content
This repository has been archived by the owner on Aug 16, 2021. It is now read-only.

Backtraces shouldn't need to be resolved unless necessary #221

Open
Marwes opened this issue Sep 19, 2017 · 3 comments
Open

Backtraces shouldn't need to be resolved unless necessary #221

Marwes opened this issue Sep 19, 2017 · 3 comments

Comments

@Marwes
Copy link

Marwes commented Sep 19, 2017

Currently backtraces are resolved immediately via Backtrace::new https://github.com/rust-lang-nursery/error-chain/blob/c9b37574d4cbcc1c27a1a72de928c77f447e56ac/src/lib.rs#L616 but the backtrace crate also supports constructing an unresolved backtrace. Is there any reason why a resolved backtrace is constructed instead of an unresolved?

If error-chain constructed a resolved backtrace lazily instead of immediately that could be a nice performance boost (as indicated by the backtrace docs).

@Yamakaky
Copy link
Contributor

Oh nice, I started rust-lang/backtrace-rs#32 but never finished it. Do you want to do a PR to integrate this feature?

@Marwes
Copy link
Author

Marwes commented Sep 19, 2017

@Yamakaky Got a bunch of projects and PRs in in progress already but if I get some time I may look into it.

I will post if I start working on this though.

@Yamakaky
Copy link
Contributor

Same ;)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants