Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What's the real MSRV for itertools? #636

Closed
cuviper opened this issue Jul 30, 2022 · 1 comment
Closed

What's the real MSRV for itertools? #636

cuviper opened this issue Jul 30, 2022 · 1 comment

Comments

@cuviper
Copy link
Contributor

cuviper commented Jul 30, 2022

Currently, itertools documents MSRV 1.32, but CI only tests 1.36.

msrv:
name: Rust MSRV
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: dtolnay/rust-toolchain@1.36.0
- run: cargo check --no-default-features
- run: cargo check --no-default-features --features "use_alloc"
- run: cargo check

The "use_alloc" feature does need Rust 1.36 for stable alloc. However, even with bare --no-default-features, Rust 1.32.0 fails on calls to checked_pow and saturating_pow, which were both stabilized in 1.34.

I ask because I'm considering MSRV 1.36 for the either crate to implement Future, rayon-rs/either#77, but I don't want to cause headaches if itertools actually wants to stay on an older MSRV.

@jswrenn
Copy link
Member

jswrenn commented Jul 30, 2022

It's just a documentation issue. Feel free to increase the MSRV of either to 1.36.

@jswrenn jswrenn closed this as completed Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants