Fix and refactor specializations tests #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, I just wanted to do this myself. Thanks! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As found in #563 specializations tests don't actually test the specialize tests due to the use of
Box<dyn Iterator>. This PR fix this problem by havingcheck_specializedbe a macro so that the code inside (what used to be the) closure directly calls methods on the iterator types.This also does a tiny refactor, moving the single test in
tests/fold_specialization.rstogether with the others intests/specializations.rs.Note that this may conflict with #563 (but I hope it doesn't since they touch different parts of the file)