Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add intersperse and intersperse_with free functions #555

Merged
merged 1 commit into from Aug 16, 2021
Merged

Add intersperse and intersperse_with free functions #555

merged 1 commit into from Aug 16, 2021

Conversation

zertosh
Copy link
Contributor

@zertosh zertosh commented Jun 22, 2021

Aside from automatic parameter conversion using IntoIterator, having
intersperse and intersperse_with as free functions makes it easier for
downstream code to avoid the unstable_name_collisions lint because of
lib core's own similarly named Iterator methods.
rust-lang/rust#48919

@phimuemue
Copy link
Member

Hi there, I agree: As long as we have intersperse in Itertools and we offer free functions, we should possibly include it in the free functions, too. However, there seems to be a problem (see CI).

@zertosh
Copy link
Contributor Author

zertosh commented Jun 30, 2021

@phimuemue, fixed! Sorry, I didn't get CI signal when I first put up the PR.

src/free.rs Show resolved Hide resolved
src/free.rs Outdated Show resolved Hide resolved
src/free.rs Show resolved Hide resolved
@phimuemue
Copy link
Member

Thank you.

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 16, 2021

Build succeeded:

@bors bors bot merged commit 4ac4f43 into rust-itertools:master Aug 16, 2021
@jswrenn jswrenn added this to the next milestone Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants