Trait impls for tuples of arity <= 12 #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
following the convention of libcore fixes rust-itertools#428 fixes rust-itertools#398
jswrenn
commented
Sep 4, 2020
Comment on lines
-288
to
+290
| loop { | ||
| $( | ||
| let $Y = if let Some($Y) = iter.next() { | ||
| $Y | ||
| } else { | ||
| break; | ||
| }; | ||
| )* | ||
| return Some(($($Y),*,)) | ||
| } | ||
|
|
||
| return None; | ||
| Some(($( | ||
| { let $Y = iter.next()?; $Y }, | ||
| )*)) |
There was a problem hiding this comment.
I think this modification is semantically equivalent, but I'd love if someone else could check it over before I merge.
There was a problem hiding this comment.
Looks good to me. Godbolt even seems to generate very similar code in --release.
off-topic: I do not have much time to spare at the moment, so I will be slow to respond.
|
Seems like a random CI failure? bors try |
tryBuild failed: |
|
bors try |
tryBuild failed: |
Merged
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I stopped at 12, because that's where libcore stops.
fixes #428
fixes #398