New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
more no_std support #470
Comments
What do you have in mind? |
So add alloc as dependency while in no_std. Most programs that use no_std already use alloc |
This will require adding new feature |
I can assure you that most no_std programs do not use alloc
…On Thu, Aug 20, 2020 at 3:11 PM Michał Majda ***@***.***> wrote:
This will require adding new feature no_std so alloc can be included only
there, and change
#[cfg(not(feature = "use_std"))] to #[cfg(feature = "no_std")]
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#470 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADPI5FCBIJTTVLV4QPNI5TSBWNQBANCNFSM4QGUL6IQ>
.
|
Still I think alloc is most reasonable option here, however I am still a beginner so I don't know other good options. |
That doesn't sound quite right to me. Crate features should add functionality, not remove it. A better approach would be to add a
...and to change this line to:
(I don't think we currently use any std-only features, so this won't be a breaking change.) @zendurix Are you actually programming in an environment that has |
I am working on adding no_std feature to project, and I am already using alloc there. I think tomorrow (at my time) I will try to add and test this feature and if it works fine I will make PR. |
I think default should stay like this: |
I have made functional PR but I have accidentally used |
I have uploaded PR |
Although itertools have no_std support it lacks implementations of most usfeful functions like collect_vec, sorted_by() etc in no_std mode. From my tests it seems that implementing it should be fairly easy, and I will try to contribute with solution.
The text was updated successfully, but these errors were encountered: