Create counts method and tests for it #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkiFire13
reviewed
Aug 18, 2020
tests/test_std.rs
Outdated
Comment on lines
916
to
928
|
|
||
| #[test] | ||
| fn counts() { | ||
| let a: [usize; 0] = []; | ||
| assert_eq!(0, a.iter().counts().len()); | ||
| let b = [1, 1, 1, 2, 2, 3]; | ||
| let b_counts = b.iter().counts(); | ||
| assert_eq!(3, b_counts.len()); | ||
| assert_eq!(Some(&3), b_counts.get(&1)); | ||
| assert_eq!(Some(&2), b_counts.get(&2)); | ||
| assert_eq!(Some(&1), b_counts.get(&3)); | ||
| assert_eq!(None, b_counts.get(&4)); | ||
| } |
There was a problem hiding this comment.
Wouldn't a quicktest be better? You can probably adapt the test I wrote in my PR for my count method:
There was a problem hiding this comment.
Yes, it would, and I've now included that. Thanks for the suggestion.
|
Looks good to me! Thanks for this! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates the function described in #467 (I went with the name
counts).It currently uses
for_eachand makes aHashMapmanually because the PR for theinto_grouping_mapfunction is still being worked on, but this function could easily be changed to call it once that PR is merged, if desired.