Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multipeek method #435

Merged
merged 1 commit into from Apr 12, 2020
Merged

Add multipeek method #435

merged 1 commit into from Apr 12, 2020

Conversation

fenhl
Copy link
Contributor

@fenhl fenhl commented Apr 11, 2020

This adds a multipeek method to the Itertools trait as a more convenient way to use the multipeek function.

@phimuemue
Copy link
Member

I wonder if we have a "standard" way of dealing with free functions vs methods.

I think we could accept this PR, but it may be worth looking into bringing all the free functions vs methods in line (e.g. by always implementing the method and having the free function call it).

There may be obstacles regarding this idea, though.

@jswrenn
Copy link
Member

jswrenn commented Apr 12, 2020

Huh, I'm surprised that there isn't parity between the free functions and methods.

bors r+

@jswrenn jswrenn added this to the next milestone Apr 12, 2020
@bors
Copy link
Contributor

bors bot commented Apr 12, 2020

Build succeeded

@bors bors bot merged commit 2c6b6ed into rust-itertools:master Apr 12, 2020
@fenhl fenhl deleted the multipeek-method branch April 12, 2020 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants