Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make TupleCollect public #387

Closed
mitsuhiko opened this issue Dec 5, 2019 · 2 comments · Fixed by #389
Closed

Make TupleCollect public #387

mitsuhiko opened this issue Dec 5, 2019 · 2 comments · Fixed by #389

Comments

@mitsuhiko
Copy link

Currently the tuple collect trait is crate internal which makes it impossible to refer to it in a function. I was trying to wrap tuple collect but this is now not possible.
@jswrenn jswrenn mentioned this issue Dec 6, 2019
Merged
@jswrenn
Copy link
Member

jswrenn commented Dec 6, 2019

@mitsuhiko, would #389 resolve your use-case?

@mitsuhiko
Copy link
Author

From looking at the diff I think the answer is yes.

bors bot added a commit that referenced this issue Jan 10, 2020
@bors @jswrenn
Merge #389
adb66f1 
389: Add `HomogeneousTuple` trait. r=jswrenn a=jswrenn

Allows clients to use certain tuple methods of `Itertools` in more generic contexts.

This trait serves as a public facade for `TupleCollect`, an internal implementation detail.

Fixes #387.

Co-authored-by: Jack Wrenn <me@jswrenn.com>
@bors bors bot closed this as completed in 1119de5 Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add HomogeneousTuple trait. jswrenn/rust-itertools
2 participants
@mitsuhiko @jswrenn