Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split embedded-can? #599

Open
reneherrero opened this issue Apr 30, 2024 · 3 comments
Open

Split embedded-can? #599

reneherrero opened this issue Apr 30, 2024 · 3 comments

Comments

@reneherrero
Copy link

Hi,

I noticed that the embedded-can crate is always pulling the nb crate even if it's not being used.

One option would be to add features. Another would be to refactor the code and follow the same pattern as the embedded-hal crates (better in my opinion).

Thoughts?

@Dirbaio
Copy link
Member

Dirbaio commented Apr 30, 2024

the nb crate is tiny, it compiles in milliseconds. If you don't use the nb stuff, code from nb doesnt end up at all on the final binary (the linker doesn't link unused code).

IMO the split is not worth the effort.

@reneherrero
Copy link
Author

Then why create an embedded-hal-nb crate? Async for CAN is also in the works #585 ...

@reneherrero
Copy link
Author

According to the stm32 bxcan project, the embedded-can crate is deprecated.

Is this the case? Understanding the state of affairs is "complicated"... even more so as far as CAN FD is concerned.

Any insight would be much appreciated,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants