Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spi: add settings to embedded-hal-bus SpiDevice impls for CS-to-clock delays. #539

Open
Dirbaio opened this issue Nov 28, 2023 · 1 comment

Comments

@Dirbaio
Copy link
Member

Dirbaio commented Nov 28, 2023

As discussed in today's meeting:

It is better if the CS-assert-to-clock and clock-to-CS-deassert delays are configured in the SpiDevice itself, so that the driver doesn't have to add them to every single transaction, and can use the read/write/write_read convenience methods.

  • add configuration settings to the SpiDevice impls in embedded-hal-bus to do the delays
  • document that drivers are discouraged from using Operation::DelayNs directly for CS-to-clocks delays.
@Dirbaio Dirbaio added this to the v1.0.0 milestone Nov 28, 2023
@Dirbaio Dirbaio removed this from the v1.0.0 milestone Dec 27, 2023
@Dirbaio
Copy link
Member Author

Dirbaio commented Dec 27, 2023

i'm going to remove this from the 1.0 milestone,

It concerns only embedded-hal-bus, we can do it in 0.1.1 in a backwards-compatible way (like adding .set_blah_delays() methods), or in 0.2 if we don't want to be compatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant