Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport non-breaking changes from v1.0 to v0.2.x #301

Merged
merged 4 commits into from Aug 1, 2021
Merged

Backport non-breaking changes from v1.0 to v0.2.x #301

merged 4 commits into from Aug 1, 2021

Conversation

burrbull
Copy link
Member

No description provided.

@rust-highfive
Copy link

r? @ryankurte

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against v0.2.x. Please double check that you specified the right target!

@burrbull burrbull marked this pull request as ready for review July 31, 2021 08:16
@burrbull burrbull requested a review from a team as a code owner July 31, 2021 08:16
Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good idea to me. Could you also add entries to the changelog about this? You can probably copy-paste them.

@burrbull
Copy link
Member Author

burrbull commented Aug 1, 2021

Could you also add entries to the changelog about this?

Done

Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 1, 2021

@bors bors bot merged commit 7199533 into rust-embedded:v0.2.x Aug 1, 2021
@eldruin eldruin mentioned this pull request Aug 3, 2021
bors bot added a commit that referenced this pull request Aug 4, 2021
303: Release 0.2.6 version r=therealprof a=eldruin

With the backported non-breaking changes from #301 

Co-authored-by: Diego Barrios Romero <eldruin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Review is incomplete T-hal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants