Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.2.x] Use nb version 0.1.3 for compatibility with nb 1.0 #253

Merged
merged 1 commit into from Apr 28, 2021
Merged

[0.2.x] Use nb version 0.1.3 for compatibility with nb 1.0 #253

merged 1 commit into from Apr 28, 2021

Conversation

eldruin
Copy link
Member

@eldruin eldruin commented Oct 2, 2020

With nb < 0.1.3 other crates cannot use nb 1.0 as the types will not match.
A new release of 0.2.x including this would be good.

@eldruin eldruin requested review from ilya-epifanov and a team as code owners October 2, 2020 09:36
@rust-highfive
Copy link

r? @ryankurte

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against v0.2.x. Please double check that you specified the right target!

@rust-highfive rust-highfive added S-waiting-on-review Review is incomplete T-hal labels Oct 2, 2020
@eldruin eldruin mentioned this pull request Oct 2, 2020
Closed
@eldruin eldruin changed the title Use nb version 0.1.3 for compatibility with nb 1.0 [0.2.x] Use nb version 0.1.3 for compatibility with nb 1.0 Oct 2, 2020
@ryankurte
Copy link
Contributor

ryankurte commented Oct 4, 2020 •
edited

i'm not opposed to this change but, shouldn't 0.1.1 already match 0.1.3 as it is interpreted as a caret requirement? seems like you should be able to cargo-update to this (tho sometimes ime you do have to delete Cargo.lock and start again).

@eldruin
Copy link
Member Author

eldruin commented Oct 5, 2020

That is correct, it would work fine after a cargo-update/Cargo.lock removal.
This is just to force it so that unmatching type errors are not possible. It recently happened to me and I figured it would be good to avoid it.

@eldruin
Copy link
Member Author

eldruin commented Nov 9, 2020

Somebody else hit this at nrf-rs/nrf-hal#264

ryankurte
ryankurte approved these changes Nov 9, 2020
View reviewed changes
Copy link
Contributor

@ryankurte ryankurte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like a decrease in compatibility but, also fair enough.

@eldruin
Copy link
Member Author

eldruin commented Nov 10, 2020

bors r=ryankurte

bors bot added a commit that referenced this pull request Nov 10, 2020
@bors @eldruin
Merge #253
9eb740c 
253: [0.2.x] Use nb version 0.1.3 for compatibility with nb 1.0 r=ryankurte a=eldruin

With `nb` < `0.1.3` other crates cannot use `nb` `1.0` as the types will not match.
A new release of 0.2.x including this would be good.

Co-authored-by: Diego Barrios Romero <eldruin@gmail.com>
@bors
Copy link
Contributor

bors bot commented Nov 10, 2020

Build failed:

@ryankurte
Copy link
Contributor

oooh, Pin API change in nightly?

---- src/lib.rs - (line 385) stdout ----
error[E0061]: this function takes 1 argument but 0 arguments were supplied
  --> src/lib.rs:442:31
   |
58 |         Pin::new(&mut blinky).resume();
   |                               ^^^^^^- supplied 0 arguments
   |

help: expected the unit value `()`; create it with empty parentheses
   |
58 |         Pin::new(&mut blinky).resume(());
   |

@eldruin
Copy link
Member Author

eldruin commented Nov 11, 2020

Indeed. Should be fixed now.

@Sh3Rm4n
Copy link
Contributor

Sh3Rm4n commented Apr 27, 2021

ping :)

@eldruin
Copy link
Member Author

eldruin commented Apr 27, 2021

bors try

bors bot added a commit that referenced this pull request Apr 27, 2021
@bors
Try #253:
c4e2f8d
@bors
Copy link
Contributor

bors bot commented Apr 27, 2021

try

Build succeeded:

@eldruin eldruin requested a review from ryankurte April 27, 2021 09:54
@ryankurte
Copy link
Contributor

lgtm, maybe we should backport the gh-actions to this too one day...

bors r+

bors bot added a commit that referenced this pull request Apr 27, 2021
@bors @eldruin
Merge #253
4f1b9e3 
253: [0.2.x] Use nb version 0.1.3 for compatibility with nb 1.0 r=ryankurte a=eldruin

With `nb` < `0.1.3` other crates cannot use `nb` `1.0` as the types will not match.
A new release of 0.2.x including this would be good.

Co-authored-by: Diego Barrios Romero <eldruin@gmail.com>
@bors
Copy link
Contributor

bors bot commented Apr 27, 2021

Timed out.

@eldruin
Copy link
Member Author

eldruin commented Apr 28, 2021

I did so in #272 I will rebase once that is merged

@eldruin eldruin force-pushed the v0.2.x-force-nb-to-version-compatible-with-1.0 branch from 9e5cd72 to cb03917 Compare April 28, 2021 08:44
ryankurte
ryankurte approved these changes Apr 28, 2021
View reviewed changes
Copy link
Contributor

@ryankurte ryankurte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

bors r+

@bors
Copy link
Contributor

bors bot commented Apr 28, 2021

Build succeeded:

@bors bors bot merged commit f85f5bd into rust-embedded:v0.2.x Apr 28, 2021
@eldruin eldruin deleted the v0.2.x-force-nb-to-version-compatible-with-1.0 branch April 28, 2021 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryankurte ryankurte ryankurte approved these changes

@ilya-epifanov ilya-epifanov Awaiting requested review from ilya-epifanov

Assignees

@ryankurte ryankurte

Labels
S-waiting-on-review Review is incomplete T-hal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eldruin @rust-highfive @ryankurte @Sh3Rm4n