Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannot find type RegisterBlock in module self::mpu on i686-pc-windows-gnu #336

Closed
dimpolo opened this issue Mar 19, 2021 · 2 comments · Fixed by #337
Closed

cannot find type RegisterBlock in module self::mpu on i686-pc-windows-gnu #336

dimpolo opened this issue Mar 19, 2021 · 2 comments · Fixed by #337

Comments

@dimpolo
Copy link
Contributor

dimpolo commented Mar 19, 2021

My default toolchain is i686-pc-windows-gnu.
I updated the cortex-m dependency today and that caused CI to break.

Presumably introduced in 1c198a1

Could this line be changed to #[cfg(not(armv8m))] ?

#[cfg(any(armv6m, armv7m, target_arch = "x86_64"))] // x86-64 is for rustdoc

@adamgreig
Copy link
Member

Yes, I think that change could be made without even a breaking change, sounds OK to me. Would you like to open a PR? Also, is there any particular reason to build cortex-m on i686? Usually in CI we'll build it for the thumb target; the only reason anything builds for x86 is because docs.rs used to require it (but these days can be told to build for the thumb targets too, so...).

@dimpolo
Copy link
Contributor Author

dimpolo commented Mar 19, 2021

Thanks for the quick response
Sure, I'll write a PR :)

The reason might be my misunderstanding of how to write no_std unit tests haha.

If I run cargo test I get can't find crate for test
So I added #![cfg_attr(not(test), no_std)] and got can't find crate for std
Which is why I ended up with cargo test --target i686-pc-windows-gnu
And the reason I use i686-pc-windows-gnu is the debugger in CLion

bors bot added a commit that referenced this issue Mar 19, 2021
337: Compile the `mpu::RegisterBlock` struct on all targets r=adamgreig a=dimpolo

closes #336

Co-authored-by: dimpolo <33688001+dimpolo@users.noreply.github.com>
@bors bors bot closed this as completed in a9fb687 Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants