Remove an extra function call in primask::read
#334
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There doesn't seem to be any reason why the call to
__primask_r
should be wrapped by another function call.read_raw
(the function being removed by this PR) is not#[inline]
, so it did hurt performance when compiled without LTO.Compare with
faultmask::read
:cortex-m/src/register/faultmask.rs
Lines 26 to 35 in 7481f09