Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: Make logging flags global #34

Merged
merged 1 commit into from Feb 9, 2022
Merged

fix!: Make logging flags global #34

merged 1 commit into from Feb 9, 2022

Conversation

epage
Copy link
Member

@epage epage commented Feb 9, 2022

This will carry them across subcommands

Fixes #33

@epage
fix!: Make logging flags global
4c0c95d 
This will carry them across subcommands

Fixes clap-rs#33
@epage epage mentioned this pull request Feb 9, 2022
Closed
@epage epage merged commit a2c2e40 into clap-rs:master Feb 9, 2022
@epage epage deleted the global branch February 9, 2022 15:32
cardil
cardil approved these changes Feb 9, 2022
View reviewed changes
Copy link

@cardil cardil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cardil cardil cardil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't be used as a global flag, together with sub-commands.
2 participants
@epage @cardil