Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle hyphens internally #197

Open
Vagelis-Prokopiou opened this issue Apr 4, 2021 · 1 comment · May be fixed by #177
Open

Handle hyphens internally #197

Vagelis-Prokopiou opened this issue Apr 4, 2021 · 1 comment · May be fixed by #177

Comments

@Vagelis-Prokopiou
Copy link

Vagelis-Prokopiou commented Apr 4, 2021

With PR #77 a note about dashes in the crate name was added in the docs. The note was of course an essential addition.

I propose going a step further and handling the dashes internally, during the parsing (parse_spec() function).
I believe this addition will save people time trying to debug the reason that the logging does not work as expected.
I myself lost some time on this, even though I had read the docs, and I had read about the need to replace the dashes.

I would also have provided a PR too, but currently I am failing to build the library (see #190 (comment)).

Is there a valid reason for not handling the dashes internally?

@Vagelis-Prokopiou Vagelis-Prokopiou changed the title Handle dashes internally Handle hyphens internally Apr 11, 2021
@mainrs
Copy link
Contributor

mainrs commented Oct 9, 2021

There is already a PR open for this: #177.

@epage epage linked a pull request Nov 10, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants