Hot Fix: Use fuzzing not feature = "fuzzing" #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the following command fails `RUSTFLAGS='--cfg=fuzzing' RUSTDOCFLAGS='--cfg=fuzzing' cargo test --all --all-features` This is because `fuzzing` is not a feature, we should be using `fuzzing` directly not `feature = "fuzzing"`. I have no idea how this got past CI.
tcharding
changed the title
|
Neat, thanks! Glad (though unsurprised) that this was only an issue in an obscure edge case (benchmarking with the fuzz-crypto enabled). |
|
I guess this breaks compilation of the fuzztests in rust-bitcoin? So we should publish another point release? |
apoelstra
approved these changes
Jun 28, 2022
Means we can't upgrade to 0.23.2 in rust-bitcoin because CI fails. 0.23.3 hear we come :) |
apoelstra
added a commit
that referenced
this pull request
Jun 29, 2022
5f611f6 Conditionally compile the hex macro (Tobin C. Harding) 69349a8 Add NIGHTLY variable to CI script (Tobin C. Harding) Pull request description: We are currently using the DO_BENCH variable as a proxy for whether or not we are using a nightly toolchain, while this is technically correct we use it from within an if guarded statement that is guarded by DO_FEATURE_MATRIX and we never run the CI script with _both_ of these variables set to true. This means that the all features test is never being run. Add a NIGHTLY variable and set it based on the output of `cargo --version`. This PR catches the bug fixed in: #466 as such it will not be able to be merged until #466 merges. ACKs for top commit: apoelstra: ACK 5f611f6 Tree-SHA512: 231bbff8e8944026183a87f681c2d7152c4dcfaaafb6cbd99404e8912d61dbc53c40bb24473c156e893c5b8de79462cb944ed94ffe5429f8b31eaef76dbc0694
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the following command fails
RUSTFLAGS='--cfg=fuzzing' RUSTDOCFLAGS='--cfg=fuzzing' cargo test --all --all-featuresThis is because
fuzzingis not a feature, we should be usingfuzzingdirectly notfeature = "fuzzing".I have no idea how this got past CI, found while trying to upgrade secp in bitcoin.This got past CI because of the feature gate combination
#[cfg(all(test, feature = "unstable"))], we never run tests on CI with both DO_FEATURE_MATRIX and DO_BENCH.