Implement de/serialization for SharedSecret #418
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we do for other keys implement serde de/serialization for the
SharedSecret
.Please note, this adds
from_slice
andfrom_bytes
(borrowed and owner respectively) because I needed to use them. Doing so treads on @dspicher's toes because he is in the process of implementing an owned conversion method forSharedSecret
. The fair thing to do would be let #417 resolve and merge before merging this one (I can rebase).Side note, its kind of rubbish that(I was bumbling nonsense.)BytesVisitor
deserializes into a buffer (presumably) then we reallocate and copy the buffer to use the borrowed conversion method due to the serde function signaturefn visit_bytes<E: de::Error>(self, v: &[u8]) -> Result<Self::Value, E>
Closes: #416