New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parity
conversion and error handling cleanup
#403
Conversation
|
Aren't we doing ecosystem-wide MSRV bump to 1.41.1? |
Sure thing. Perhaps we could have a label for 'will work once we bump MSRV' to help us queue these changes up and to save others checking what the CI fail is about? |
7d66770
to
e0767d3
Compare
Spurious CI error |
Looks like CI is working again -- but PR still needs update if we're going to get it into this major version (which does not increase MSRV) |
ACK cf6badf aside from the |
This removes the deprecated `From` conversion and adds a new error type for the invalid parity error with a conversion to the catch-all `Error`.
e0767d3
to
5acf6d2
Compare
Fixed (changed to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 5acf6d2
This removes the deprecated
From
conversion, replaces it withTryFrom
, and adds more convenience conversions. A new error type iscreated for the invalid parity error with conversion to catch-all
Error
.This is intended for an API-breaking version.