Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

secp256k1: Remove secp256k1_sys types from the public API #655

Open
tcharding opened this issue Oct 24, 2023 · 2 comments
Open

secp256k1: Remove secp256k1_sys types from the public API #655

tcharding opened this issue Oct 24, 2023 · 2 comments

Comments

@tcharding
Copy link
Member

If we want to be able to stabalize this crate and release a v1.0 we either have to stabalize secp256k1_sys or remove all the ffi types from the public API.

Since the secp256k1_sys crate may never stabalize we should proactively wrap/hide/remove the secp256k1_sys types from the public API.
@tcharding tcharding changed the title Remove secp256k1_sys types from the public API secp256k1: Remove secp256k1_sys types from the public API Oct 24, 2023
@tcharding tcharding mentioned this issue Oct 24, 2023
Merged
@apoelstra
Copy link
Member

Yeah, I guess you're correct.

I wonder if we should still export secp256k1-sys itself. Maybe under a new name that is clearly marked _unstable?

@Kixunil
Copy link
Collaborator

Kixunil commented Oct 24, 2023

Clearly marked _unstable is good, I've seen most, if not all, crates to also put it behind a feature flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Kixunil @apoelstra @tcharding