Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve definition of the Message struct #619

Open
Harshil-Jani opened this issue Jun 24, 2023 · 1 comment · May be fixed by #620
Open

Improve definition of the Message struct #619

Harshil-Jani opened this issue Jun 24, 2023 · 1 comment · May be fixed by #620

Comments

@Harshil-Jani
Copy link

/// A (hashed) message input to an ECDSA signature.
#[derive(Copy, Clone)]
pub struct Message([u8; constants::MESSAGE_SIZE]);

This is not only used in ECDSA Signature, It is also used into the signing of schnorr signature.

pub fn sign_schnorr(&self, msg: &Message, keypair: &KeyPair) -> Signature {

@Harshil-Jani Harshil-Jani changed the title Improve defination of the Message struct Improve definition of the Message struct Jun 24, 2023
@apoelstra
Copy link
Member

Sure, we should say that it's input to an "EC signature" and also document which values are invalid.

@Harshil-Jani Harshil-Jani linked a pull request Jun 25, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants