-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
impl_array_newtype in FFI should not autoderive std::Hash #463
Comments
Fixed by #506 ? |
506 only does Do we need to do the fuzzing thing that we do on |
Only if those types already have a different representation while fuzzing. IOW if it works without thinking about fuzzing, that's the way to go. |
I'm not currently able to find all the discussion we had on this ord/cmp stuff. I've done #515 that fixes ord/cmp at the level of |
I like the idea of providing As for "where is the correct layer to do this", I'm fine either way: we could add these impls in |
In our FFI module we implement the std::Hash trait by hashing the contents of the inner array ... but the contents of these arrays for FFI types is not guaranteed to be consistent between different copies of the library. We shoud instead be serializing the data and comparings serializations.
The same applies to Ord and Eq.
related #462
The text was updated successfully, but these errors were encountered: