New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit FFI methods return values #455

Open

sanket1729 opened this issue Jun 21, 2022 · 1 comment

Member

sanket1729 commented Jun 21, 2022

The rust type system can provide some guarantees w.r.t calling arguments of FFI functions

We can cleanly document the cases in which the FFI method can return an Error (supplying a negation of tweak in an add_tweak method), or safely unwrap them if our type system guarantees it.
I also some while reviewing Add convenience methods for keys #430 that were addressed in the same PR.

sanket1729 mentioned this issue

Remove mentions of 32-byte slice from tweak APIs #453

Merged

Member Author

sanket1729 commented Jun 21, 2022

I can do this in a couple of weeks. But if somebody wants to do it, it's up for grabs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment