Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use upstream script_code_p2wpkh API #364

Closed
sanket1729 opened this issue Apr 20, 2022 · 2 comments · Fixed by #512
Closed

Use upstream script_code_p2wpkh API #364

sanket1729 opened this issue Apr 20, 2022 · 2 comments · Fixed by #512
Labels
post 0.29

Comments

@sanket1729
Copy link
Member

After rust-bitcoin/rust-bitcoin#954 and rust-bitcoin 0.29 release, we can use the new API to cleanup script_code_p2wpkh here to cleanup manual calculation in psbt/mod.rs
@sanket1729 sanket1729 added good first issue Good for newcomers post 0.29 and removed good first issue Good for newcomers labels Apr 20, 2022
@tcharding
Copy link
Member

I can't find any code manually building the script code - is this issue still live?

@sanket1729
Copy link
Member Author

sanket1729 commented Dec 30, 2022 •
edited

It is still used

rust-miniscript/src/psbt/mod.rs

Line 1258 in 7664570

fn script_code_wpkh(script: &Script) -> Script {

tcharding added a commit to tcharding/rust-miniscript that referenced this issue Dec 31, 2022
@tcharding
Use p2wpkh_script_code from rust-bitcoin
1329f6c 
Currently we have a function to construct the script code for a P2WPKH,
this code is now upstream in `rust-bitcoin` so we can use it.

Fix: rust-bitcoin#364
tcharding added a commit to tcharding/rust-miniscript that referenced this issue Dec 31, 2022
@tcharding
Use p2wpkh_script_code from rust-bitcoin
b98e2e0 
Currently we have a function to construct the script code for a P2WPKH,
this code is now upstream in `rust-bitcoin` so we can use it.

Fix: rust-bitcoin#364
@tcharding tcharding mentioned this issue Dec 31, 2022
Merged
sanket1729 added a commit that referenced this issue Jan 1, 2023
@sanket1729
Merge #512: Use p2wpkh_script_code from rust-bitcoin
a0648b3 
842ae93 Use p2wpkh_script_code from rust-bitcoin (Tobin C. Harding)

Pull request description:

  Currently we have a function to construct the script code for a P2WPKH, this code is now upstream in `rust-bitcoin` so we can use it.

  Fix: #364

ACKs for top commit:
  sanket1729:
    ACK 842ae93

Tree-SHA512: 0510c7c12a8ad85947e7bb02d3cb1ca876af15d47b934688404562f49b9b2f195fb3ec2c4a0fff01b51bec1f0a4a2fa1eeccaf556c18b81570b2fbe69ef27806
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
post 0.29
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use p2wpkh_script_code from rust-bitcoin tcharding/rust-miniscript
2 participants
@sanket1729 @tcharding