Add PSBT alias #951
Merged
Add PSBT alias #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Programmers are inherently lazy and for good reason. I'm yet to see anyone write `PartiallySignedTransaction` in code that uses `rust-bitcoin`, its too obvious to add a type alias for PSBTs, let's just do it ourselves to save everyone else having to do so. Add public type alias `Psbt` for `PartiallySignedTransaction`.
|
lgtm every piece of consumer code I've seen using psbt has this alias. 👍 |
apoelstra
approved these changes
Apr 20, 2022
|
Agreed, I also use the same alias. |
ChallengeDev210
pushed a commit
to ChallengeDev210/rust-bitcoin
that referenced
this pull request
Aug 1, 2022
f92854a Add PSBT alias (Tobin Harding) Pull request description: Programmers are inherently lazy and for good reason. I'm yet to see anyone write `PartiallySignedTransaction` in code that uses `rust-bitcoin`, its too obvious to add a type alias for PSBTs, let's just do it ourselves to save everyone else having to do so. Add public type alias `Psbt` for `PartiallySignedTransaction`. ACKs for top commit: apoelstra: ACK f92854a sanket1729: ACK f92854a Tree-SHA512: 1f56ac236d34a89bbb557ada147f05d8a8ce961dad3ad921f10f26c597b91ecc8e15070f8825774745e5333ba5282962830a3cc0c53b93f147be93ab566b1b9e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Programmers are inherently lazy and for good reason. I'm yet to see
anyone write
PartiallySignedTransactionin code that usesrust-bitcoin, its too obvious to add a type alias for PSBTs, let'sjust do it ourselves to save everyone else having to do so.
Add public type alias
PsbtforPartiallySignedTransaction.