Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade bech32 to version 0.9.0 #1131

Merged
merged 1 commit into from Jul 27, 2022

Conversation

tcharding
Copy link
Member

Recently rust-bech32 v0.9.0 was released, this release included
updating the MSRV to 1.41.1.

Recently `rust-bech32` v0.9.0 was released, this release included
updating the MSRV to 1.41.1.
@tcharding tcharding mentioned this pull request Jul 27, 2022
3 tasks
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK c67f74b

Copy link
Collaborator

@Kixunil Kixunil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK c67f74b

@Kixunil Kixunil added API break This PR requires a version bump for the next release P-high High priority trivial Obvious, easy and quick to review (few lines or doc-only...) labels Jul 27, 2022
@Kixunil Kixunil added this to the 0.29.0 milestone Jul 27, 2022
@apoelstra apoelstra merged commit a550fa8 into rust-bitcoin:master Jul 27, 2022
@tcharding tcharding deleted the 07-27-upgrade-bech32 branch July 27, 2022 22:20
ChallengeDev210 pushed a commit to ChallengeDev210/rust-bitcoin that referenced this pull request Aug 1, 2022
c67f74b Upgrade bech32 to version 0.9.0 (Tobin C. Harding)

Pull request description:

  Recently `rust-bech32` v0.9.0 was released, this release included
  updating the MSRV to 1.41.1.

ACKs for top commit:
  apoelstra:
    ACK c67f74b
  Kixunil:
    ACK c67f74b

Tree-SHA512: 59aac2f40e0bc8c63a7549a988ff7cdc114ca7768421c7926cc6badbaa1d4f9de0c5cf41d987e4f5124a5c9042650e722cf5fbd892e91d0232ac175122eb042d
apoelstra added a commit that referenced this pull request Aug 8, 2022
110b5d8 Bump version to v0.29.0 (Tobin C. Harding)

Pull request description:

  Add changelog notes and bump the version number to v0.29.0.

  ## Notes

  I attempted to go through all the PRs since last release, please sing out if you had a PR merged that is not mentioned and you would like it mentioned.

  The changelog notes can be changed or improved, please do not take me writing them to imply I know exactly what goes on round here - I just made an effort to save others having to do it.

  ## TODO
  - [x]  merge all 'required' PRs
    - #1131
    - #1137
    - #1129
    - #1151
    - #1165 (add release notes still)
  - [x] Ensure all green from the CI run on: rust-bitcoin/rust-miniscript#450
  - [ ] Carry out (and improve) the #1106

ACKs for top commit:
  tcharding:
    ACK 110b5d8
  Kixunil:
    ACK 110b5d8
  apoelstra:
    ACK 110b5d8
  sanket1729:
    reACK 110b5d8

Tree-SHA512: d00c70534476794c01cd694ea9a23affef947c4f913b14344405272bc99cc00763f1ac755cc677e7afbd3dbef573d786251c9093d5dbafd76ee0cf86ca3b0ebd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API break This PR requires a version bump for the next release P-high High priority trivial Obvious, easy and quick to review (few lines or doc-only...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants