Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to secp v0.24.0 #1110

Merged

Conversation

tcharding
Copy link
Member

We just released a new version of rust-secp256k1, lets use it.

This also fixes a bug where we upgraded our bitcoin_hashes dependency
before secp had done theirs.

We just released a new version of `rust-secp256k1`, lets use it.

This also fixes a bug where we upgraded our `bitcoin_hashes` dependency
before secp had done theirs.
@tcharding tcharding mentioned this pull request Jul 20, 2022
3 tasks
Copy link
Member

@sanket1729 sanket1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK df73576

@sanket1729 sanket1729 added the one ack PRs that have one ACK, so one more can progress them label Jul 20, 2022
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK df73576

@apoelstra apoelstra merged commit 148b56a into rust-bitcoin:master Jul 20, 2022
@tcharding tcharding deleted the 07-20-upgrade-secp-dependency branch July 20, 2022 22:25
ChallengeDev210 pushed a commit to ChallengeDev210/rust-bitcoin that referenced this pull request Aug 1, 2022
df73576 Upgrade to secp v0.24.0 (Tobin C. Harding)

Pull request description:

  We just released a new version of `rust-secp256k1`, lets use it.

  This also fixes a bug where we upgraded our `bitcoin_hashes` dependency
  before secp had done theirs.

ACKs for top commit:
  sanket1729:
    utACK df73576
  apoelstra:
    ACK df73576

Tree-SHA512: 614eb096203753a6581e444aa11d41c7060342afd7ad103f6118c64bccf604850819ec2852730d1ac83fdea193770fe7600ea70c082a19afaef7ad3e8016d0e4
@Kixunil Kixunil added this to the 0.29.0 milestone Aug 1, 2022
@Kixunil Kixunil added the API break This PR requires a version bump for the next release label Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API break This PR requires a version bump for the next release one ack PRs that have one ACK, so one more can progress them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants