Why do we have two SigHashTypes?

[dr-orlovsky]

First one:

https://github.com/rust-bitcoin/rust-bitcoin/blob/master/src/blockdata/transaction.rs#L676-L695

Second one:

https://github.com/rust-bitcoin/rust-bitcoin/blob/master/src/util/sighash.rs#L102-L126

[RCasatta]

The second one has the Reserved variant, here are some comments about it:

#628 (comment)

Nobody was super-sure about it, we can decide to remove it before release

[RCasatta]

Sorry, my previous comment was pertinent but not the real reason, the real reason it's the Default variant added in Bip341

[dr-orlovsky]

Can we somehow differentiate them by name, do a deprecated stuff on the old one or add necessary doc explanations on the choice of the structure?

[apoelstra]

Lol, let's just remove the one in transaction.rs

[sanket1729]

Lol, let's just remove the one in transaction.rs

If we do so, we would have to add checks to existing methods to not use the new variants. At which I think that having two separate types is the correct thing.

[dr-orlovsky]

If we have to maintain both structures we need to differentiate them by name and clearly describe the purpose of both in the docs

[RCasatta]

Also, I think we are re-exporting the legacy one

rust-bitcoin/src/lib.rs

Line 125 in a961ab4

pub use blockdata::transaction::SigHashType;