Fix release 0.26.2 #611
Merged
Fix release 0.26.2 #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes rust-bitcoin#608. In rust-bitcoin#567 the Display impl for ChildNumber was consciously changed, assuming the semver break would not affect any correctly implemented downstream projects. We were wrong.
sgeisler
force-pushed
the
2021-06-fix-release
branch
from
9211dcb
to
055d0fb
Compare
sanket1729
approved these changes
Jun 8, 2021
There was a problem hiding this comment.
Verified that this fixes rust-miniscript downstream.
ack 055d0fb
apoelstra
reviewed
Jun 8, 2021
|
|
||
| The previous release changed the behavior of `Display` for `ChildNumber`, assuming that any correct usage would not be | ||
| affected. [Issue 608](https://github.com/rust-bitcoin/rust-bitcoin/issues/608) goes into the details of why this isn't | ||
| the case and how we broke both `rust-miniscript` and BDK. |
There was a problem hiding this comment.
There is a trailing space here, but I'll let it go.
apoelstra
approved these changes
Jun 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We broke downstream with 0.26.1, I propose yankign it and releasing 0.26.2. This fixes #608 and closes #609 .