Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert commit following 0.26.1 release #564

Closed
dr-orlovsky opened this issue Jan 30, 2021 · 1 comment
Closed

Revert commit following 0.26.1 release #564

dr-orlovsky opened this issue Jan 30, 2021 · 1 comment
Assignees
@dr-orlovsky
Milestone
0.28.0

Comments

@dr-orlovsky
Copy link
Collaborator

dr-orlovsky commented Jan 30, 2021 •
edited

Revert PSBT: use non-API break error type for Base64 encoding error

Since introduction of the new error type is an API break this commit is created to prevent it and get the Base64 serialization into the minor release. After that the commit should be reverted so with the next major version release there will be a new Base64-serialization-specific error variant

Also, if appropriate, fix #557 (review)
@dr-orlovsky dr-orlovsky added this to the 0.27.0 milestone Jan 30, 2021
@dr-orlovsky dr-orlovsky self-assigned this Jan 30, 2021
@dr-orlovsky dr-orlovsky changed the title Revert commit https://github.com/rust-bitcoin/rust-bitcoin/pull/557/commits/b4077213ab311bed2a4faaaae3600d9949b867a6 following 0.26.1 release Revert commit following 0.26.1 release Jan 30, 2021
@dr-orlovsky dr-orlovsky mentioned this issue Jan 30, 2021
Merged
@dr-orlovsky
Copy link
Collaborator Author

Closing since it is outdated: the original PR is now non-API breaking and it is followed by an API-breaking #574; no commits has to be reverted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dr-orlovsky dr-orlovsky

Labels
None yet
Projects
None yet
Milestone
0.28.0
Development

No branches or pull requests
1 participant
@dr-orlovsky