Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

master still has version set to 0.32.0-rc1 #2724

Open
tcharding opened this issue Apr 27, 2024 · 4 comments · May be fixed by #2729
Open

master still has version set to 0.32.0-rc1 #2724

tcharding opened this issue Apr 27, 2024 · 4 comments · May be fixed by #2729

Comments

@tcharding
Copy link
Member

tcharding commented Apr 27, 2024 •
edited

I've done something wrong during the release process; master should be on version 0.32.0 now too.
@tcharding
Copy link
Member Author

Found with: rust-bitcoin/rust-bitcoin-maintainer-tools#2

That tool is "so hot right now" :)

@apoelstra
Copy link
Member

I've done something wrong during the release process; master should be on version 0.32.0 now too.

So, in many projects we would set it to "0.32.99" or something goofy like that to emphasize to any users that this is a pre-release. In Rust it might make sense to put it as 0.33.0.pre.

Alternaely we could set it to 0.32.0 as you suggest. But I don't think it's wrong for it to deviate from any release branches.

@tcharding
Copy link
Member Author

No worries, if it doesn't matter lets just leave it as is.

@apoelstra
Copy link
Member

Well, I think leaving it at an rc number is still misleading and we ought to change it. It's true that it "doesn't matter" in the sense that anybody using master will be pinning by git rev rather than by semver version, but I still think we should choose something that won't be confused with a real revision.

@apoelstra apoelstra reopened this Apr 29, 2024
tcharding added a commit to tcharding/rust-bitcoin that referenced this issue Apr 29, 2024
@tcharding
bitcoin: Set version number
d4256c8 
During the recent release cycle we left `bitcoin` on the last rc
version.

Set the version number to the current release, as it is for all the
other crates in the workspace.

Close: rust-bitcoin#2724
@tcharding tcharding linked a pull request Apr 29, 2024 that will close this issue
Open
tcharding added a commit to tcharding/rust-bitcoin that referenced this issue Apr 29, 2024
@tcharding
bitcoin: Set version number
5666b72 
During the recent release cycle we left `bitcoin` on the last rc
version.

Set the version number to the current release, as it is for all the
other crates in the workspace.

Close: rust-bitcoin#2724
tcharding added a commit to tcharding/rust-bitcoin that referenced this issue May 2, 2024
@tcharding
bitcoin: Set version number
91eed01 
During the recent release cycle we left `bitcoin` on the last rc
version.

Set the version number to `v0.33.0-unreleased` to make it obvious what
it is.

Close: rust-bitcoin#2724
tcharding added a commit to tcharding/rust-bitcoin that referenced this issue May 2, 2024
@tcharding
bitcoin: Set version number
46e0ce5 
During the recent release cycle we left `bitcoin` on the last rc
version.

Set the version number to `v0.33.0-unreleased` to make it obvious what
it is.

Close: rust-bitcoin#2724
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bitcoin: Set version number tcharding/rust-bitcoin
2 participants
@apoelstra @tcharding