New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for API breaking changes in CI #1875
Comments
We should definitely be using cargo-semver-checks -- though bearing in mind that it's still very incomplete and we can't blindly trust an "ok" from it.
|
Whats the status of this one crew, do we want it in before next release? The one on |
I'm not sure there should be rush but I want it eventually, definitely before 1.0 of any crate. Doing it sooner has the advantage of being able to auto-label PRs. |
Let's just rebase #1880 and do it here, since Kix is onboard. The history here is that we tried opening #1880 and got no reply from Kix after several weeks and were unable to move forward. So we switched to doing it in leaf crates where we didn't need Kix's approval (e.g. in rust-secp rust-bitcoin/rust-secp256k1#656 and in rust-bech32). Then in rust-bech32 we have gotten no reply from Clark for several weeks :). For what it's worth, it's worked great in rust-secp ... but that's not worth much since the API for rust-secp never changes :). But since Kix is online and in favor of this, I think we should just pull the trigger instead of waiting on rust-bech32. |
Just to clear the respond Clark did respond, it was back waiting on @Kixunil (because of merge strategy proposed by me). No one is really at fault here. Anyways, I'll rebase and YOLO - if there are too many teething problems we can always revert. |
As we move towards a 1.0 release it would be nice to check CI that we don't make breaking changes. Consider using
The text was updated successfully, but these errors were encountered: