New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make hex an optional dep for hashes #2654
Comments
Yep! I believe we had discussed this earlier. I think we want to do the hash trait splitting as part of the same effort (see #2496). |
I tried searching but can't find or remember why one should not feature gate trait implementations. Furthermore I don't understand why this issue mentions sealed traits. To make |
|
But yes, we would definitely need to feature-gate |
Oh that's right we literally had this conversation a week ago you noted that |
One quick and dirty thing I tried was just printing |
No, we should definitely either support it "properly" (ok to have crappy support for format specifiers initially but we should aim to have it complete by 1.0) or have it not compile. |
I really do like this option but because of orphan rule it leaves |
ISTM hex isn't really all that "required" to do hashing, and personally I'd very much like to use bitcoin_hashes with ~zero dependencies (with potentially eyeing building outside of cargo). It seems making hex an optional dependency is pretty easy, just requires actually adding the right feature tags (and maybe one or two sealed traits). Is this something folks would be open to?
The text was updated successfully, but these errors were encountered: