Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base58::Vec in error message is odd #2653

Open
tcharding opened this issue Apr 3, 2024 · 3 comments
Open

base58::Vec in error message is odd #2653

tcharding opened this issue Apr 3, 2024 · 3 comments

Comments

@tcharding
Copy link
Member

If one gets a compile error because of incorrect type and a Vec is expected the error message is odd, here is an example:

     = note: expected enum `psbt::SigningKeys`
              found struct `base58::Vec<crypto::key::PublicKey>`

Something somewhere is getting confused.

@tcharding tcharding changed the title vec!/Vec is being imported from base58 base58::Vec in error message is odd Apr 3, 2024
@apoelstra
Copy link
Member

I blame rust-lang/rust#121708 which has forced us to write increasingly arcane invocations to get Vec into our code, which in turn seems to be confusing rustc.

@tcharding
Copy link
Member Author

Yeah I had the same feeling (although I did not have a rust-lang link). Seems like a regression and will be likely fixed upstream, we can just sit tight and not action this issue, right?

@apoelstra
Copy link
Member

Yeah, I think it's fine to just sit tight. I definitely don't think we should try to take action by second-guessing the compiler's path resolution in error messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants