You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In commit 678eee8d7388 Use Message::from_digest we replaced Message::from_digest_slice(hash.as_byte_array()) with Message::from_digest(hash.to_byte_array()) however we failed to notice that we can go one step further because the sighash hash types implement secp256k1::ThirtyTwoByteHash and use Message::from(hash).
The text was updated successfully, but these errors were encountered:
We definitely did not "fail to notice" this. The use of the ThirtyTwoByteHash trait is the cause of all our "dependency hole" problems related to coordinating rust-bitcoin releases, though I can never remember the exact mechanism of our pain.
In commit
678eee8d7388 Use Message::from_digest
we replacedMessage::from_digest_slice(hash.as_byte_array())
withMessage::from_digest(hash.to_byte_array())
however we failed to notice that we can go one step further because the sighash hash types implementsecp256k1::ThirtyTwoByteHash
and useMessage::from(hash)
.The text was updated successfully, but these errors were encountered: