Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shoosh semver informational part build warning #2590

Open
tcharding opened this issue Mar 13, 2024 · 0 comments
Open

Shoosh semver informational part build warning #2590

tcharding opened this issue Mar 13, 2024 · 0 comments

Comments

@tcharding
Copy link
Member

When we merged #2572 we introduced a build warning

warning: /home/tobin/build/github.com/tcharding/rust-bitcoin/02-15-improve-base58/bitcoin/Cargo.toml: version requirement `0.105.0+25.1` for dependency `bitcoinconsensus` includes semver metadata which will be ignored, removing the metadata is recommended to avoid confusion

At the time I was too lazy to see if we could shoosh it - I believe we should keep using the full version (incl. the informational +25.1). Seeing the warning everytime we build is annoying though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant