Inherent functions to_bytes / from_bytes

[tcharding]

All types that have a fixed length binary encoding should have inherent functions:

• to_bytes or into_bytes (depending on naming convention)
• from_bytes

If the type implements the consensus traits then the encoding produced by to_bytes should match that produced by consensus_encode.

references

• Rust naming conventions: https://rust-lang.github.io/api-guidelines/naming.html
• Original idea: Overloading of serialization terms #2187 (comment)

Please consider doing #1458 at the same time.

[tcharding]

This issue needs concept ack'ing by other maintainers please.

[apoelstra]

concept ACK from me.

[Kixunil]

I feel like I already opened this but too lazy to search. Anyway, maybe to_consensus_bytes/from_consensus_bytes instead?

[apoelstra]

I'd be okay with that, though these names would be a bit less discoverable.

[15IITian]

I feel like I already opened this but too lazy to search.

@Kixunil , Do you mean this #1458 ?

[tcharding]

Oh yes that one is similar, should be done at the same time. Leaving this one open too because of the differences.