Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

units: Audit all types for correct usage of Ord vs ArbitraryOrd #2580

Open
tcharding opened this issue Mar 13, 2024 · 4 comments
Open

units: Audit all types for correct usage of Ord vs ArbitraryOrd #2580

tcharding opened this issue Mar 13, 2024 · 4 comments
Labels
1.0 Issues and PRs required or helping to stabilize the API C-units PRs modifying the units crate

Comments

@tcharding
Copy link
Member

Not all types have an order but putting types into struct that require Ord is common, this is what we wrote the ordered crate for.

Audit all the types in units and check that they correctly either derive Ord and PartialOrd or implement ArbitraryOrd.

@tcharding tcharding added 1.0 Issues and PRs required or helping to stabilize the API C-units PRs modifying the units crate labels Mar 13, 2024
@15IITian
Copy link
Contributor

I'll take this up

@tcharding
Copy link
Member Author

Oh woops, I should have mentioned originally but I was thinking of after #2569 lands - there is currently only the amount types in units. My bad.

@15IITian
Copy link
Contributor

there is currently only the amount types in units.

Yeah , I was pretty confused initially -> but now I see there are other types too which are related to amounts so can check them until #2569 got merge.

@15IITian
Copy link
Contributor

15IITian commented Mar 13, 2024

Recently I checked after merging of #2569 and IMO , Everything looks fine .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.0 Issues and PRs required or helping to stabilize the API C-units PRs modifying the units crate
Projects
None yet
Development

No branches or pull requests

2 participants