Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin serde to 1.0.142 #1178

Merged
merged 1 commit into from Aug 10, 2022
Merged

Pin serde to 1.0.142 #1178

merged 1 commit into from Aug 10, 2022

Conversation

Kixunil
Copy link
Collaborator

@Kixunil Kixunil commented Aug 9, 2022

1.0.143 bumps MSRV higher than what we support.

Closes #1175

Unfortunately I have to go now, will try to get back ASAP.

@Kixunil Kixunil marked this pull request as ready for review August 9, 2022 12:52
@Kixunil Kixunil force-pushed the pin-serde branch 4 times, most recently from 708271e to 75366eb Compare August 9, 2022 13:47
@apoelstra
Copy link
Member

Frustrating. We'll have to also put back the README blob telling users to do this.

@Kixunil
Copy link
Collaborator Author

Kixunil commented Aug 9, 2022

Yes, but I'd rather merge this and #1177 ASAP to minimize the damage and worry about doc later.

@Kixunil
Pin serde to 1.0.142
7a28a56 
1.0.143 bumps MSRV higher than what we support.
apoelstra
apoelstra approved these changes Aug 9, 2022
View reviewed changes
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 75366eb

@Kixunil
Copy link
Collaborator Author

Kixunil commented Aug 9, 2022

I have to run again, please re-run tests in #1177 if this is merged while I'm gone.

apoelstra
apoelstra approved these changes Aug 9, 2022
View reviewed changes
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 7a28a56

tcharding
tcharding approved these changes Aug 10, 2022
View reviewed changes
Copy link
Member

@tcharding tcharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 7a28a56

@tcharding
Copy link
Member

I'm a little bit confused. In this CI run the 1.41.1 test pass but not the 1.47.1 and I can run tests locally with +1.41.1. I see that its the cargo tree command that fails, but for some reason cargo tree does not accept a toolchain. What am I missing?

@Kixunil
Copy link
Collaborator Author

Kixunil commented Aug 10, 2022

@tcharding regarding 1.41 vs 1.47 it's caused by (IMO not great) process of introducing changes to cargo. Unknown fields added to Cargo.toml are ignored, but if there's actually a new unstable feature using them they start causing errors and when it's stabilized they start work fine. So there's a weird hole where things don't work.

@apoelstra apoelstra merged commit 9a606fc into rust-bitcoin:master Aug 10, 2022
sanket1729 added a commit to sanket1729/rust-miniscript that referenced this pull request Aug 11, 2022
@sanket1729
Pin serde to 1.0.142
bd934f2 
Complimentary to rust-bitcoin/rust-bitcoin#1178
@sanket1729 sanket1729 mentioned this pull request Aug 11, 2022
Merged
sanket1729 added a commit to sanket1729/rust-miniscript that referenced this pull request Aug 14, 2022
@sanket1729
Pin serde to 1.0.142
cd8da9e 
Complimentary to rust-bitcoin/rust-bitcoin#1178
apoelstra added a commit to rust-bitcoin/rust-miniscript that referenced this pull request Aug 14, 2022
@apoelstra
Merge #454: Pin serde to 1.0.142
9fd9aa4 
cd8da9e Pin serde to 1.0.142 (sanket1729)

Pull request description:

  Similar to rust-bitcoin/rust-bitcoin#1178

ACKs for top commit:
  apoelstra:
    utACK cd8da9e

Tree-SHA512: 14de10187973272cacc1b6278f32fec2e266d1507a4548fe224f146b74bfcf6b2b5e8fb61cae66d7b13232bb073c88ca1a6f94a36def75773382cef975a101f0
joemphilips pushed a commit to joemphilips/rust-miniscript that referenced this pull request Dec 9, 2022
@sanket1729 @joemphilips
Pin serde to 1.0.142
923e5ee 
Complimentary to rust-bitcoin/rust-bitcoin#1178
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoelstra apoelstra apoelstra approved these changes

@tcharding tcharding tcharding approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pin serde in tests
3 participants
@Kixunil @apoelstra @tcharding