Address::from_script to return a Result

[dpc]

#1021 (comment)

[sanket1729]

Added another fail condition to be checked: #1021 (comment)

[Eunoia1729]

Picking this up

[nlanson]

Added another fail condition to be checked: #1021 (comment)

@sanket1729 Is this check not already performed when script.is_witness_program() is called within Payload::from_script()?

Relevant code:

rust-bitcoin/src/util/address.rs

Lines 397 to 402 in 09b4198

	} else if script.is_witness_program() {
	Payload::WitnessProgram {
	version: WitnessVersion::from_opcode(opcodes::All::from(script[0])).ok()?,
	program: script[2..].to_vec(),
	}
	} else {

rust-bitcoin/src/blockdata/script.rs

Lines 547 to 551 in 09b4198

	WitnessVersion::from_opcode(ver_opcode).is_ok()
	&& push_opbyte >= opcodes::all::OP_PUSHBYTES_2.to_u8()
	&& push_opbyte <= opcodes::all::OP_PUSHBYTES_40.to_u8()
	// Check that the rest of the script has the correct size
	&& script_len - 2 == push_opbyte as usize

[sanket1729]

@nlanson, you are correct! This is already being done. Sorry for the confusion. But as far as this issue is concerned, we should have a dedicated error variant here.