Replies: 1 comment 1 reply
-
I think your individual changes are fairly clearly motivated. Thanks for building a tree of PRs like this but I think I'm content to review the non-draft ones (currently #67 and #71) as they come undrafted. Though probably I will take a look at #69 to understand the direction you're taking with the reversed-string stuff. |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
The current hex stuff I've done is pretty wild and is all entangled. I imagine it is going to be a nightmare to be able to ack things.
To help showcase everything I put all the patches on rust-bitcoin/hex-conservative#64 and then did #2473 to prove that it all works.
I'm open to any suggestions that will make the review/merge process easier. FTR the only PR that I think is contentious is the backwards stuff in rust-bitcoin/hex-conservative#67
I can't actually remember right at this minute how I got to thinking that we need a new release ofhex
for the nextrust-bitcoin
release, I'll post that if/when I remember or find therust-bitcoin
work that requires it.We can't do #2474 without fixing
hex
because ofbitcoin::string
. So unless we are willing to releaseunits
with just theamounts
module then therust-bitcoin
release is blocked on all this hex stuff.Beta Was this translation helpful? Give feedback.
All reactions