Replies: 11 comments 28 replies
-
|
This is just based on my current view of the world, those with write perms please update with your own views. Anyone else who wants to see something in the next release please post and I"ll update the message above. |
Beta Was this translation helpful? Give feedback.
-
|
|
Beta Was this translation helpful? Give feedback.
-
|
If there are any issues you guys would like to see done before next release can you add them to the project backlog please and I'll pick them up. |
Beta Was this translation helpful? Give feedback.
-
|
What I wanted was a way to visually link dependencies between issues/PRs i.e. this blocks that. But I couldn't work this out. |
Beta Was this translation helpful? Give feedback.
-
|
Milestone is easier to work with than editing a discussion and you can filter by it. |
Beta Was this translation helpful? Give feedback.
-
|
Oh I mean the "projects" feature of github: https://github.com/orgs/rust-bitcoin/projects/8 I did this issue with the links to try and help visualize whats got to be done instead of having a list. I'm 100% open to better ways to do this, I'm not doing the project management because its fun, just because I think it needs doing. Best/easiest/cleanest/fastest way possible is good for me. |
Beta Was this translation helpful? Give feedback.
-
|
I really just need a list of issues/PRs that need to be done. And setting a milestone is faster than copy-pasting. |
Beta Was this translation helpful? Give feedback.
-
|
Added the milestone, I'm going to attempt to use projects for the other crate releases that are required for |
Beta Was this translation helpful? Give feedback.
-
|
I am becoming increasingly concerned that we are going to blow wildly past this end-of-march release date. We are doing invasive changes to hex stuff (mainly error code) that effects |
Beta Was this translation helpful? Give feedback.
-
|
I don't mind being "roughly" every six months, but if we routinely slip by multiple months, I think we need to be more agressive about "just shipping" stuff. It's true that we have some knowingly-broken things, but most of these knowingly-broken things are ancient parts of the codebase and it'll take multiple release cycles to fix them all. Personally I would rather have multiple "progressively-less-broken" releases than widely-interspersed releases that do a ton at once and take a ton of effort and ugliness to update. (Though @stevenroose has argued to me elsewhere that frequent releases can also be a PITA since multiple other library authors feel obligated to update their crates immediately, even if in-principle we expect end-users to be batching updates. But I think part of why this is painful is that we're breaking too much at once.) |
Beta Was this translation helpful? Give feedback.
-
|
Or maybe we need longer freeze periods, better planning etc. |
Beta Was this translation helpful? Give feedback.
-
|
With how unknown the work involved in crate smashing is (who know hex would take the amount of time it is taking) I'm not sure we can plan much better, at least I don't know how, without reading a book on project management (which I don't plan on doing). But it seems if we get a push that "we realy want XYZ in next release" then as the release approaches we need to soften up on "XYZ must be perfect". I think we should follow more strictly the old mantra "release early, release often" instead of trying to make everything perfect. |
Beta Was this translation helpful? Give feedback.
-
|
Maybe we should define our priorities. My idea was to try releasing So the question is are you even on board with this idea? What are the alternatives? |
Beta Was this translation helpful? Give feedback.
-
If we do this then it will take forever to release Once we are close to |
Beta Was this translation helpful? Give feedback.
-
|
I think we should stick to the six months release cadence we have achieved recently, to do so we have to release all the other crates in the |
Beta Was this translation helpful? Give feedback.
-
|
Its two weeks until the end of March crew, we have a whole bunch of open PRs and issues that are marked milestone 0.32 and we need to get cracking on releasing the stack of crates. Could anyone with review time please sort by milestone and throw some ACKs. @sanket1729 I have only marked the hex stuff as priority because otherwise I'd mark all the milestone 0.32 stuff but that seems redundant. |
Beta Was this translation helpful? Give feedback.
-
|
I've triaged all open PRs of my own and non-maintainers and added the "milestone 0.32.0", converted to draft (or asked author to do so). Shall we soft feature freeze soon and try and get this release done? |
Beta Was this translation helpful? Give feedback.
-
|
Oh I meant the gratuitous changes bit - which by definition wouldn't be considered gratuitous if I'd just done the PR :) Jokes aside I can most definitely attempt to do the bdk update during the RC cycle of |
Beta Was this translation helpful? Give feedback.
-
|
Agreed, let's say that it's a prereq that we have a draft PR open for rust-miniscript, bdk, bech32 and rust-elements. I'm not sure exactly how to do bdk because it depends on rust-miniscript -- maybe we should do an actual rc of rust-miniscript which uses the rc of rust-bitcoin? I'd like to also have a draft PR open for BitVM but they're currently several versions behind (and off on a temporary fork of Steven's with some stuff we can't upstream during feature freeze). So for 0.33 let's target that. |
Beta Was this translation helpful? Give feedback.
-
I won't remember where this thread is later on to reference it but can we agree that I do miniscript and bdk and you do elements? bech32 is a mistake in your comment I believe, did you mean something else?
I can do the PRs to include patch sections in the manifest to point to the correct branches then you can pull it down locally to check them (if you want), CI clearly won't work though (because of
I've checked in with them: BitVM/BitVM#23 |
Beta Was this translation helpful? Give feedback.
-
|
Yeah, sorry, bech32 is a mistake. But yes, I will do elements (and maybe elements-miniscript and rust-simplicity, if I get practiced enough at using |
Beta Was this translation helpful? Give feedback.
-
|
Pro tip which I often forget, you have to have patch sections for all the crates in |
Beta Was this translation helpful? Give feedback.
-
|
Lets go! |
Beta Was this translation helpful? Give feedback.
-
|
The first release candidate should have dropped already and we have a whole bunch of open PRs still. Any maintainers available to help out reviewing would be super appreciated (@apoelstra will totally buy you a beer when he sees you :) |
Beta Was this translation helpful? Give feedback.
-
TODO list for
|
Beta Was this translation helpful? Give feedback.
-
|
cc @apoelstra just to spam you because I can't remember where I mentioned base58ck release, |
Beta Was this translation helpful? Give feedback.
-
|
Three tasks to go boys. Lets get the RC out this week, come on! |
Beta Was this translation helpful? Give feedback.
-
|
Hey crew, I've upgraded all crates up to and including
All the test branches are pushed up to my forks and a draft PR is opened on each repo. Branch name is
For a more complete list see the top entries of https://github.com/pulls?q=is%3Aopen+is%3Apr+author%3Atcharding+archived%3Afalse+Depend+on+bitcoin |
Beta Was this translation helpful? Give feedback.
-
Shall we shoot for end of March?
Please use milestone 0.32.0 to add PRs and issues that you'd like to see get into the next release.
Beta Was this translation helpful? Give feedback.
All reactions